Fix track file

[normelton]

Pull Request (PR) description

This PR solves two issues related to keepalive configuration:

• For versions of keepalived < 2.1.0, the "track_file" config stanza should be called "vrrp_track_file". The manpage for keepalived.conf confirms the deprecation, I found the exact version by digging through the source code for keepalived.
• The previous implementation of this module allowed a particular file to have a given weight, but when the track_file was referenced inside the vrrp_instance, the weight was reassigned to "1". According to the keepalived.conf manpage, the weight defined inside vrrp_instance defaults to weight configured in track_file. It should be safe to remove.

This Pull Request (PR) fixes the following issues

Fixes #278

[bastelfreak]

thanks for the PR/email. Please take a look at the inline comments and the other datatypes you added. If you read the code correctly, this is only a bugfix and shouldn't breaking existing installations?

[normelton]

Okay, so I realized a corner-case. This patch depends on knowing the value of the keepalived_version fact. That's fine, as long as keep alive is installed. But if you're deploying keepalive with this module, then the fact doesn't have a value until the package is installed. The code here will complain that the fact value doesn't exist.

I think I need to withdraw this PR and reconsider. A few possibilities:

• Without a fact value, assume the latest version & syntax. The first "puppet apply" might push out an invalid syntax, which would be resolved on subsequent invocations when the fact is present.
• Abandon the keepalived_version fact, and allow the user to specify a version of keepalived in their puppet manifest. Without a version specified, assume the latest. This is less "magical", but works.
• Allow the user to configure either a vrrp_track_file or track_file in their puppet manifest, and assume they know which syntax is required for their specific version of keepalived.

Thoughts?

[bluthg]

Duh, I had my fix (#282) lying around for ~ as long as this PR is open... maybe we should join forces? ;-)

[normelton]

Duh, I had my fix (#282) lying around for ~ as long as this PR is open... maybe we should join forces? ;-)

Yeah your solution is much simpler. I tried to make it automagically work, but that gets complicated. I’m closing this PR and upvoting yours.