search

voxpupuli / puppet-keepalived

Puppet Module to manage Keepalived
https://forge.puppet.com/puppet/keepalived
Apache License 2.0
49 stars 152 forks source link

Improve track_file handling and enable vrrp_track_file for keepalived < 2.1.0 #282

Closed bluthg closed 1 year ago

bluthg commented 1 year ago

Pull Request (PR) description

keepalived < 2.1.0 used (uses, it's e.g. in Ubuntu 20.04) "vrrp_track_file" instead of "track_file". The PR uses a pragmatic approach to enabling this by simply cloning the type & code. Tested @ client, works as expected.

Also, the current implementation sets a hardcoded "weight" (to 1, which is the default anyway), but the "track_file" (and now "vrrp_track_file") has that as a parameter, so we should honour that.

And since the parameter is called "@param track_file" but actually wants an array, adds that to the description.

This Pull Request (PR) fixes the following issues

278

bluthg commented 1 year ago

Linking to #278 and #281

normelton commented 1 year ago

Thanks, looking forward to this being released

bastelfreak commented 1 year ago

@bluthg can you please rebase against our latest master branch to get rid of the merge commits?

bluthg commented 1 year ago

@bluthg can you please rebase against our latest master branch to get rid of the merge commits?

Uh oh, me and git...

bluthg commented 1 year ago

And now the deletion of .puppet-lint.rc is in the MR again... sigh!

bluthg commented 1 year ago

@bastelfreak, think we can merge it the way it is now?