voxpupuli / puppet-keepalived

Puppet Module to manage Keepalived
https://forge.puppet.com/puppet/keepalived
Apache License 2.0
49 stars 151 forks source link

Replace all occurrences of illegal chars in the name var #291

Closed gerases closed 7 months ago

gerases commented 1 year ago

Pull Request (PR) description

gerases commented 1 year ago

I'm not sure of the reason for the failed builds. It's not me right?

smortex commented 1 year ago

Debian 9 and Ubuntu 16.04 are EOL, you can ignore failures (if you want, you can rebase on top of master to integrate their removal):

From your working directory:

git fetch origin         # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
git push -f              # Send the changes (-f is required because you re-wrote history)
zilchms commented 7 months ago

Hey @gerases, can you rebase this and fix the merge conflicts? :) If the CI passes then, I can merge it

gerases commented 7 months ago

@zilchms , done, let me know if you need me to do anything else