search

voxpupuli / puppet-keepalived

Puppet Module to manage Keepalived
https://forge.puppet.com/puppet/keepalived
Apache License 2.0
49 stars 150 forks source link

Improve collect_unicast_peers #305

Closed frank-f closed 8 months ago

frank-f commented 9 months ago

Pull Request (PR) description

As described in #304, collect_unicast_peers will add the local source IP to the list of unicast_peers. Currently this is a rather cosmetic problem, but it may confuse someone unfamiliar with the module who's looking at the configuration file. Also, the ideal contents for unicast_src_ip which will match the rest of the configuration is determined by the module, but it is never explicitly added to it. Instead we're relying on Keepalived to come to the same result. I added it to the template (still overridable by setting unicast_source_ip explicitly) and moved it's fragment below "if $collect_unicast_peers" for this to work.

This Pull Request (PR) fixes the following issues

Fixes #304

bastelfreak commented 8 months ago

@frank-f can you please rebase?

bastelfreak commented 8 months ago

this looks a bit odd. The PR contains commits that are already in master. Can you take a look again and rebase please? If you've questions about it you can always join our IRC channel #voxpupuli on Libera.Chat.