voxpupuli / puppet-keepalived

Puppet Module to manage Keepalived
https://forge.puppet.com/puppet/keepalived
Apache License 2.0
49 stars 150 forks source link

Needed to add vmac support #91

Open stevedwray opened 8 years ago

stevedwray commented 8 years ago

Hi, I needed to add vmac support so I made the following patch I hope you can integrate this for the future:

diff -ru /etc/puppet/environments/development/modules/keepalived/manifests/vrrp/instance.pp arioch-keepalived-1.2.3/manifests/vrrp/instance.pp
--- /etc/puppet/environments/development/modules/keepalived/manifests/vrrp/instance.pp  2016-02-12 18:17:03.405480812 +0000
+++ arioch-keepalived-1.2.3/manifests/vrrp/instance.pp  2015-11-06 08:42:18.000000000 +0000
@@ -164,8 +164,6 @@
   $unicast_source_ip          = undef,
   $unicast_peers              = undef,
   $dont_track_primary         = false,
-  $use_vmac                   = false,
-  $vmac_xmit_base             = false,

 ) {
   $_name = regsubst($name, '[:\/\n]', '')
diff -ru /etc/puppet/environments/development/modules/keepalived/templates/vrrp_instance.erb arioch-keepalived-1.2.3/templates/vrrp_instance.erb
--- /etc/puppet/environments/development/modules/keepalived/templates/vrrp_instance.erb 2016-02-12 18:18:48.851261492 +0000
+++ arioch-keepalived-1.2.3/templates/vrrp_instance.erb 2015-08-04 14:26:22.000000000 +0000
@@ -5,15 +5,6 @@
   priority                  <%= @priority %>
   advert_int                <%= @advert_int %>
   garp_master_delay         <%= @garp_master_delay %>
-
-  <%- if @use_vmac -%>
-  use_vmac
-  <%- end -%>
-
-  <%- if @vmac_xmit_base -%>
-  vmac_xmit_base
-  <%- end -%>
-
   <%- if @lvs_interface -%>
   lvs_sync_daemon_interface <%= @lvs_interface %>
   <%- end -%>
arioch commented 8 years ago

Hi @stevedwray

Could you wrap this in a pull request? I'd prefer you to have the proper credits for this patch instead of my name showing up instead.

If you're unsure how to create a pull request don't hesitate to ask, I'll help you through the process.

saz commented 4 years ago

Support has been added with the merge of #108 This issue can be closed.