voxpupuli / puppet-kibana

Kibana Puppet module by Elastic.
Apache License 2.0
16 stars 48 forks source link

Allow '.' to appear in package release strings. #39

Closed bugfood closed 1 week ago

bugfood commented 4 years ago

Packages for RedHat/CentOS commonly have versions like: 1.2.3-4.el7

Here's an example in the wild: https://cbs.centos.org/koji/buildinfo?buildID=12210 The page contains: "Information for build kibana-4.5.4-2.el7"

...and locally-built packages may follow this pattern, as in the case I encountered.

Without this change, such package versions fail input validation.

Pull request acceptance prerequisites:

bugfood commented 4 years ago

This is a trivial one-character change, plus an 11-character addition to the tests. Do you really need a CLA signature for that?

The tests failed for a reason unrelated to my patch: Debian 7 could not fetch security updates, presumably because it is end-of-life.

vox-pupuli-tasks[bot] commented 2 years ago

Dear @bugfood, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 2 years ago

Dear @bugfood, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

bugfood commented 1 week ago

We are no longer using this patch locally, due to our use of newer packages. If anybody ever needs this, it should be simple to resurrect.

-Corey