Feature/refactor with options - Githubissues

voxpupuli / puppet-kmod

manage kernel module with puppet

Apache License 2.0

17 stars 63 forks source link

Feature/refactor with options #27

Closed crayfishx closed 9 years ago

crayfishx commented 9 years ago

This is a bit of a refactor after I wanted to add in the ability to do options too. The main points are:

kmod::options support
Refactored "generic" into kmod::setting which is implemented by alias, install, option and blacklist to try and reduce the amount of duplicated augeas stuff.
Doc updates

raphink commented 9 years ago

Come to think of it, I'd like to create a 2.x branch for this and move kmod::generic into an augeas provider.

raphink commented 9 years ago

@mcanevet what do you think?

mcanevet commented 9 years ago

@raphink +1 for the augeas provider

raphink commented 9 years ago

@mcanevet I mostly meant about creating a 2.x branch to work on a new version (including an augeas provider)

raphink commented 9 years ago

I created a 2.x branch so we can get started with this. Ideally, I'd like to replace kmod::generic with a kernel_module type & augeas provider.

raphink commented 9 years ago

I've merged this into the 2.x branch as 5b74b8ef576b964f2cd289a47c6c2247bc9fccf9. Let's move from there and try to see what we can do to keep improving it, using Augeas providers.