search

voxpupuli / puppet-kmod

manage kernel module with puppet
Apache License 2.0
17 stars 63 forks source link

Add kmod fact #44

Closed jcpunk closed 2 years ago

jcpunk commented 6 years ago

This is an initial stab at #33

jcpunk commented 6 years ago

in theory I've just fixed up the requested bits.

raphink commented 6 years ago

I went ahead and tested this fact (I hadn't really before).

I made a few fixes (including some that cancel changes I'd requested which actually don't work) on https://github.com/raphink/puppet-kmod/tree/pull/44

jcpunk commented 6 years ago

Looks good to me, I've applied the changes and flattened the patch

jcpunk commented 6 years ago

Just checking back in.

jcpunk commented 6 years ago

Good call ;)

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kenyon commented 2 years ago

This fact causes warnings on puppet runs on some systems (depending on what modules are loaded), such as these:

Warning: Facter: Permission denied @ rb_sysopen - /sys/module/md_mod/parameters/new_array
Warning: Facter: Operation not permitted @ io_fread - /sys/module/kdb/parameters/enable_nmi

Not sure if there's anything we can do about it. It does make puppet runs kind of scary-looking for people who don't know what causes these warnings, though.

jcpunk commented 2 years ago

Does https://github.com/voxpupuli/puppet-kmod/pull/78 help?