search

voxpupuli / puppet-kmod

manage kernel module with puppet
Apache License 2.0
17 stars 63 forks source link

Ignore kmod fact read errors #81

Closed jcpunk closed 2 years ago

jcpunk commented 2 years ago

Pull Request (PR) description

The more targeted rescue seems to have a few edges I didn't expect. This PR just puts all the errors into the facter debug level. This should let folks track them if needed, but hide the results for the various edges folks are encountering.

This Pull Request (PR) fixes the following issues

Fixes #79

silug commented 2 years ago

I can confirm that this eliminates the

Warning: Facter: Operation not permitted @ io_fread - /sys/module/kdb_main/parameters/enable_nmi

message that I see on CentOS 7 without the change.

jcpunk commented 2 years ago

I'll look into reworking this as something less intrusive, but for now can we get this merged so folks at least aren't actively bugged with the read errors?

gcoxmoz commented 2 years ago

Runs cleanly on both CentOS7 and 8, does what it says, comments make sense explaining why values/errors are being suppressed.