search

voxpupuli / puppet-kmod

manage kernel module with puppet
Apache License 2.0
17 stars 63 forks source link

Load modules config only for modules managed by puppet (#90) #91

Open deric opened 2 years ago

deric commented 2 years ago

Pull Request (PR) description

Avoid exporting all loaded kernel modules as facts.

Only loaded modules will be exported (970 lines -> 16 lines)

$ facter -y --puppet kmods
kmods:
  br_netfilter:
    parameters: {}
    used_by: []
  overlay:
    parameters:
      check_copy_up: "N"
      index: "N"
      metacopy: "N"
      nfs_export: "N"
      permit_mounts_in_userns: "N"
      redirect_always_follow: "Y"
      redirect_dir: "N"
      redirect_max: '256'
      xino_auto: "N"
    used_by: []

Too many facts might overload puppetserver or slow down puppet runs.

This Pull Request (PR) fixes the following issues

Fixes #90

fraenki commented 10 months ago

@deric, would you please rebase? It has merge conflicts now. Would love to see this getting merged rather sooner than later. :)

deric commented 10 months ago

@fraenki Yeah, sure. This is a bit old, I don't recall the details.

deric commented 10 months ago

@fraenki Rebased, please test this. It might be breaking change for some setups.

deric commented 9 months ago

@fraenki Rebased

jordyb6 commented 4 days ago

What's the status on this? Can this get merged?

yakatz commented 4 days ago

What is the chance there is anyone relying on this fact the way it currently works?