search

voxpupuli / puppet-logrotate

Puppet logrotate module
https://forge.puppet.com/puppet/logrotate
MIT License
26 stars 92 forks source link

Fix FreeBSD group issue #194

Closed Toutzn closed 2 years ago

Toutzn commented 2 years ago

in this file, the user and group are defined as root. in other files you use params which are defined with values in the param file as you check the OS before.

Pull Request (PR) description

the user and group name was hardcoded defined as root which produce exception on freebsd (no group with root are available.

This Pull Request (PR) fixes the following issues

I removed the hardcoded names and changed it into you predefined vars from params.pp which will filled with the right values for OS.

Toutzn commented 2 years ago

Hi. Can you please push this into the master and generate a new version number to use this package via puppet-labs Thanks a lot

BR Torsten

kapouik commented 2 years ago

188 is allready covering this change.

root-expert commented 2 years ago

Hello @Toutzn , this needs basic units tests before it can be merged at master.