search

voxpupuli / puppet-logrotate

Puppet logrotate module
https://forge.puppet.com/puppet/logrotate
MIT License
26 stars 93 forks source link

Update defaults to match RHEL8/9 #195

Closed jcpunk closed 2 years ago

jcpunk commented 2 years ago

Pull Request (PR) description

RHEL8 and later use a slightly different default for wtmp

This Pull Request (PR) fixes the following issues

N/A

bastelfreak commented 2 years ago

Thanks for the PR. Can you please add CentOS 8/9 to metadata.json?

jcpunk commented 2 years ago

Done

bastelfreak commented 2 years ago

can you please take a look at the failing tests?

jcpunk commented 2 years ago

I have no idea why these tests are failing.... there is something amiss with the OS detection code but that is beyond me....

jcpunk commented 2 years ago

Updated with the suggested form.

jcpunk commented 2 years ago

I honestly don't see how these changes are suddenly making the self tests fail the group ownership or file ensures....

jcpunk commented 2 years ago

Rebased following latest module sync

jcpunk commented 2 years ago

The failures I'm showing are part of the existing failure set.