search

voxpupuli / puppet-logrotate

Puppet logrotate module
https://forge.puppet.com/puppet/logrotate
MIT License
26 stars 93 forks source link

updated dependency is a breaking change between 7.0.1->7.0.2 #223

Open sirinek opened 6 months ago

sirinek commented 6 months ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

Using module defaults

What are you seeing

Switching from 7.0.1 to 7.0.2 has a dependency of systemd 6.3.0 or newer. 7.0.1 had no such dependency and did not complain about having puppet-systemd module version 3.2.0 installed.

What behaviour did you expect instead

I expected a point release to work on its own and not break. Or at least mention the new requirement in the changelog.

Output log

root@myhost # puppet agent -tv --environment=bsirinek_puppet7
Info: Using environment 'bsirinek_puppet7'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Unknown resource type: 'systemd::manage_dropin' (file: /opt/puppetlabs/server/data/puppetserver/filesync/client/versioned-dirs/puppet-code/bsirinek_puppet7_0d23d9c10c7eb581006bf79ecc53376bed613711/modules/logrotate/manifests/hourly.pp, line: 41, column: 5) on node myhost.company.com

Any additional information you'd like to impart

Currently testing our modules for upgrade to newer PE that uses puppet7. Will upgrade to the newer systemd.

thomas-pean commented 3 months ago

Hello Same issue for us, the additional dependency broke our installations. This breaking change should have been in a major version or highlighted in the changelog.

That's not a major issue and the workaround is easy to implement but it's always a pain to have regressions on a minor version.

Keep up the good work, thanks.