voxpupuli / puppet-logstash

Puppet module to manage Logstash
https://forge.puppet.com/elastic/logstash
Apache License 2.0
191 stars 299 forks source link

logstash: config,patternfile respect `$::logstash::ensure` #411

Open damonbreeden opened 2 years ago

damonbreeden commented 2 years ago

otherwise if a server has ensure => false but still calls logstash::configfile for any reason the file will try to be created but fail bc /etc/logstash does not exist

e.g. in your private base.pp you say

include logstash
logstash::configfile {
  ...
}

but somewhere in hiera you don't want to install logstash on a cluster so you have logstash::ensure: absent

damonbreeden commented 2 years ago

ping 🙏

smortex commented 1 year ago

Wait, we do have CI in this project. I try to trigger it by closing and re-opening it…

bastelfreak commented 1 year ago

@damonbreeden please rebase against our latest master branch to get rid of the merge commit.