search

voxpupuli / puppet-logstash

Puppet module to manage Logstash
https://forge.puppet.com/elastic/logstash
Apache License 2.0
191 stars 299 forks source link

Modulesync 5.4.0 #418

Closed h-haaks closed 1 year ago

h-haaks commented 2 years ago

Fixes #391, #400, #402, #408

h-haaks commented 2 years ago

@bastelfreak could you please have a look at this.

ekohl commented 1 year ago

I'll also note that our current modulesync config is at 5.3.0 so perhaps you could also include that. If you need help with that, please let me know.

h-haaks commented 1 year ago

@ekohl I have fixed your comments now and I had a look at https://github.com/voxpupuli/modulesync_config to see if I could fix that as well. I think I need some help with this ..

h-haaks commented 1 year ago

Hmm, it seems like puppet-logstash is missing in https://github.com/voxpupuli/modulesync_config/blob/master/managed_modules.yml

h-haaks commented 1 year ago

@ekohl, @bastelfreak Could you please have another look at this? I think it would be smart to get this merged before the 5.4.0 release of modulesync.

h-haaks commented 1 year ago

Should README.md have been updated according to the elastic -> voxpupuli transition and logstash version constraints adjusted to supported versions?

kenyon commented 1 year ago

@h-haaks yes (in a separate pull request).

ekohl commented 1 year ago

I think it would be smart to get this merged before the 5.4.0 release of modulesync.

The differences between 5.3.0 and 5.4.0 are trivial so I'd include that here.

h-haaks commented 1 year ago

The differences between 5.3.0 and 5.4.0 are trivial so I'd include that here.

Is it ok to run msync from the master branch before the 5.4.0 tag is created?

h-haaks commented 1 year ago

Generally I'm not too happy about making changes in the code itself in a modulesync PR, but if it gets the module moving forward I'm happy to approve.

I do agree. All of this is just parts of transitioning this module into voxpupuli, I think. The modulesync commits are just part of that. I'll gladly change the title to something like 'Get module to build with voxpupuli'.

ekohl commented 1 year ago

Is it ok to run msync from the master branch before the 5.4.0 tag is created?

I think @bastelfreak forgot to push a tag because he did create https://github.com/voxpupuli/modulesync_config/commit/2f1495fadadb102d600a4093e06368ea89684f33 so just go for it.

h-haaks commented 1 year ago

@ekohl I don't have write access to the repository. Could you please merge this PR?

ekohl commented 1 year ago

Thanks for taking this over the finish.