search

voxpupuli / puppet-mode

Edit Puppet manifests with GNU Emacs 24
https://github.com/voxpupuli/puppet-mode
GNU General Public License v3.0
90 stars 60 forks source link

new release? #117

Closed anarcat closed 4 years ago

anarcat commented 5 years ago

the last release here is 5 years old, and there seems to have been much work done since then. could we tag a new release? this would be useful for the Debian packaging work in progress.

thanks!

bastelfreak commented 5 years ago

Hi @anarcat, this repository got migrated to us and I'm not very familiar with Emacs. Do you just require a new git tag?

anarcat commented 5 years ago

yep!

anarcat commented 5 years ago

ping! can we get a new tag here? 0.4 would do. ;) i'd be happy to push one to my fork if that helps...

sten0 commented 5 years ago

@bastelfreak, gentle ping to please tag a release at your earliest convenience. +1 on version 0.4, because a 0.3.1 isn't significant enough to indicate a change of maintainer IMHO. On that topic, modify the following lines to accurately define the current maintainer[s] before tagging a new release https://github.com/voxpupuli/puppet-mode/blob/7dee1b5a5debac6e56f9107492a413b6c0edb94d/puppet-mode.el#L10-L11

Thank you for maintaining puppet-mode! P.S. I maintain the Debian package :-)

sten0 commented 5 years ago

Also, it looks like 0.4 is what the previous maintainers intended: https://github.com/voxpupuli/puppet-mode/blob/7dee1b5a5debac6e56f9107492a413b6c0edb94d/puppet-mode.el#L14

It might also be a good idea to drop the -cvs suffix before tagging ;-)

sten0 commented 4 years ago

@voxpupuli, @pccibot, @bastelfreak

Gentle ping for the new version. See https://github.com/voxpupuli/puppet-mode/issues/117#issuecomment-509805652 and https://github.com/voxpupuli/puppet-mode/issues/117#issuecomment-509806722 for trivially easy changes that should be made before tagging the release.

bastelfreak commented 4 years ago

@sten0 can you provide patches for that?

sten0 commented 4 years ago

Done, at #121. Could you take care of checking my work on CHANGES.md and continuing to update it with the history since 0.3?

sten0 commented 4 years ago

P.S. @anarcat if bastelfreak needs help with CHANGES.md today, and if you're free, could you finish the remaining ~30% of work? I need a break :-)

anarcat commented 4 years ago

P.S. @anarcat if bastelfreak needs help with CHANGES.md today, and if you're free, could you finish the remaining ~30% of work? I need a break :-)

I'm confused: how do you expect me to do that with your existing PR?

not knowing any better way, i took your branch and finished the CHANGES changes and pushed to a new PR, in #122.

once #122 is merged, we just need to push a tag and we're done. i don't seem to have access to do that here, that said, even if i'm a member of the @voxpupuli org, so i'm a bit confused by that.

anarcat commented 4 years ago

@bastelfreak would love to release this, but i don't have the credentials to push, i believe. would you mind doing the honors or sharing the wealth? :)

anarcat commented 4 years ago

actually, i can push tags too, so this is done. :)