search

voxpupuli / puppet-mode

Edit Puppet manifests with GNU Emacs 24
https://github.com/voxpupuli/puppet-mode
GNU General Public License v3.0
90 stars 60 forks source link

Fix infinite loop when indenting defined type #96

Closed darkfeline closed 7 years ago

darkfeline commented 7 years ago

https://github.com/voxpupuli/puppet-mode/issues/77

rski commented 7 years ago

Thanks for the PR, but this doesn't seem to fix the reported issue. I added the code from the issue to the tests and they just hang:

~/Code/puppet-mode on  darkfeline-indent-define! ⌚ 10:48:21
$ make test
cask exec ert-runner 
Running tests on Emacs 25.1.1
Loading /home/rski/Code/puppet-mode/puppet-mode.el (source)...

Indenting region...
Indenting region...done

Indenting region...
Indenting region...done

Indenting region...
Indenting region...done

Indenting region...
Indenting region...done

Indenting region...
Indenting region...done

Indenting region...
Indenting region...done

Indenting region...
Indenting region...done

Indenting region...
darkfeline commented 7 years ago

Attempted proper fix, which is more invasive.

darkfeline commented 7 years ago

Could I have this looked at again?

rski commented 7 years ago

Hi @darkfeline , sorry I was awol for a bit but im taking a look now :-)

rski commented 7 years ago

looks good, thank you so much for this @darkfeline and all the other patches. Would you be interested in joining voxpupuli and helping maintain puppet-mode?

darkfeline commented 7 years ago

Sorry for the delayed response, I was on vacation.

I would be glad to join, although I cannot promise spending time looking over issues or PRs beyond what's relevant to my work.