search

voxpupuli / puppet-mongodb

mongodb installation
Apache License 2.0
93 stars 451 forks source link

Support Suse enterprise repository #719

Closed h-haaks closed 8 months ago

h-haaks commented 8 months ago

Pull Request (PR) description

Adding support for Suse enterprise repository

h-haaks commented 8 months ago

Should we add opensuse to metadata to get it tested?

h-haaks commented 8 months ago

Should we add opensuse to metadata to get it tested?

Tried to run beaker with opensuse15-64 and docker but it seems like beaker-docker is still using the old and deprecated amd64/opensuse/leap images ...

h-haaks commented 8 months ago

I would like to see these moved to module data, so code gets a lot simpler, I was thinking of having 2 parameters, 1 for the community edition and one for the enterprise edition.

Do you mean two repo location params? Thats a bit odd if the class should only manage one repo.

stevenpost commented 8 months ago

I would like to see these moved to module data, so code gets a lot simpler, I was thinking of having 2 parameters, 1 for the community edition and one for the enterprise edition.

Do you mean two repo location params? Thats a bit odd if the class should only manage one repo.

Yes, then the code can do something like:

$_real_repo = $use_enterprise_repo ? {
  true    => $community_repo,
  default => $enterprise_repo,
}

If going with a single parameter, it needs to be undef by default and we end up with a huge select for the OS as well.