search

voxpupuli / puppet-monit

Puppet module to manage monit installation and configuration
https://forge.puppetlabs.com/soli/monit
Apache License 2.0
0 stars 21 forks source link

old syntax detected #11

Closed maxadamo closed 2 years ago

maxadamo commented 5 years ago

hey,

I noticed some syntax which are now deprectaed. for instance: 

validate_integer
validate_....

I can help with that... I hope you're open to PRs

maxadamo commented 5 years ago

fixed by #12 few points:

  1. the commit is quite big. I don't know how easy or doable it is to analyse the whole change :disappointed:
  2. it's a breaking change, as I am forcing few Booleans and Integer. I thought (but I am not sure) that allowing strings and booleans, and integers and strings, adds entropy). Feel free to comment and we can change it.
  3. I see that PDK requires some work... I made some small improvement, but it's still broken.
maxadamo commented 2 years ago

no more relevant