search

voxpupuli / puppet-monit

Puppet module to manage monit installation and configuration
https://forge.puppetlabs.com/soli/monit
Apache License 2.0
0 stars 21 forks source link

Add amazon linux2 support #3

Closed erik-frontify closed 6 years ago

erik-frontify commented 6 years ago

This is the currently available Amazon Linux 2 version.

Without that fix it will be recognized as RHEL 4.

FlorentPoinsaut commented 6 years ago

Hello, Thank you for this PR. I don't kown Amazon Linux 2 but why it's operatingsystemmajrelease is 4 ? Regards,

erik-frontify commented 6 years ago

Hi Florent,

Me neither ;-(

Looks like it is derived from the used kernel version of Amazon Linux 2, but in fact it is the first time I'm using Amazon Linux 2. So just guessing.

This is the os fact hash:

facter os { architecture => "x86_64", family => "RedHat", hardware => "x86_64", name => "Amazon", release => { full => "4.14.47-64.38.amzn2.x86_64", major => "4", minor => "14" }, selinux => { enabled => false } }

And kernel version is: uname -r 4.14.47-64.38.amzn2.x86_64

And sorry for the pull request mess I created. I'm unfortunately not used to write/adjust tests or doing pull requests in general ;-/

HTH,

Erik

On Mon, Jul 9, 2018 at 10:36 PM Florent Poinsaut notifications@github.com wrote:

Hello, Thank you for this PR. I don't kown Amazon Linux 2 but why it's operatingsystemmajrelease is 4 ? Regards,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/solution-libre/puppet-monit/pull/3#issuecomment-403611704, or mute the thread https://github.com/notifications/unsubscribe-auth/AmTeuCzwQbh_tAdlHZ7JXETJcMmcOvqnks5uE77RgaJpZM4VH4Nu .

--

Erik Geiger DevOps Engineer Unterstrasse 4, 9000 St. Gallen Switzerland

frontify.com, blog.frontify https://frontify.com/blog, twitter.frontify https://twitter.com/frontify