search

voxpupuli / puppet-network

Types and providers to manage network interfaces
https://forge.puppet.com/puppet/network
Apache License 2.0
66 stars 108 forks source link

make module rubocop clean #141

Closed igalic closed 8 years ago

igalic commented 8 years ago

currently our builds are failing because of rubocop

rski commented 8 years ago

A lot of failures are related to failing with fail instead of raise. The official puppet docs use raise when failing

igalic commented 8 years ago

we can do these transforms automatically with rubocop -a :D

igalic commented 8 years ago

@rski wanna help with this, and then with #102? :D

rski commented 8 years ago

I've been eyeing #102 for a while cause I'd really like to be able to track a stable package instead of just master. Problem is I don't really know what needs to be done for that.

This weekend is a three day one, so I might just do the rubocop cleanup because it doesn't look too time consuming.

igalic commented 8 years ago

if you need a hand, you can come to irc (freenode/#voxpupuli) and we'll give you a hand

jyaworski commented 8 years ago

Yes, please use the latest modulesync_config which takes the rake update into account.

rski commented 8 years ago

Cool, I'll join the irc from my home client