search

voxpupuli / puppet-network

Types and providers to manage network interfaces
https://forge.puppet.com/puppet/network
Apache License 2.0
66 stars 108 forks source link

static IPv6 routes are not supported on debian #164

Closed igalic closed 5 years ago

igalic commented 8 years ago

at least not through /etc/network/routes. You could still set them through /etc/network/interfaces with post-up and & pre-down rules.

jyaworski commented 8 years ago

@igalic tests fail. Can you look?

igalic commented 8 years ago

@jyaworski the tests are failing, because they expect to succeed ;)

bastelfreak commented 8 years ago

@igalic could you please take a look here again?

igalic commented 8 years ago

thanks for the reminder, this totally fell off my radar :(

jyaworski commented 8 years ago

@igalic also rebase for new tests.

igalic commented 8 years ago

rebased and --force pushed tests still failing i guess this is maybe what my stash was all about?????

rski commented 8 years ago

@igalic the tests started failing again at some point, so you'll have to rebase again before you start working on this

igalic commented 8 years ago

i'm still not sure if this is an issue with my changes, or with our tests. example of a failure:

  8) Puppet::Type::Network_route when validating the attribute value netmask converts IPv6 netmasks of the CIDR form
     Failure/Error: raise("IPv6 routes are not supported on Debian") if a.ipv6? && Facter.value(:osfamily) == 'Debian'

     Puppet::ResourceError:
       Parameter network failed on Network_route[lxd bridge]: Validate method failed for class network: IPv6 routes are not supported on Debian                                                                                                                                 
     # ./lib/puppet/type/network_route.rb:24:in `block (3 levels) in <top (required)>'
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/parameter.rb:452:in `validate'
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/property.rb:483:in `block in should='
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/property.rb:483:in `each'
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/property.rb:483:in `should='
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/property.rb:535:in `value='
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/type.rb:673:in `[]='
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/type.rb:2429:in `block in set_parameters'
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/type.rb:2423:in `each'
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/type.rb:2423:in `set_parameters'
     # /home/igalic/.gem/ruby/2.3.1/gems/puppet-4.4.2/lib/puppet/type.rb:2379:in `initialize'
     # ./spec/unit/type/network_route_spec.rb:58:in `new'
     # ./spec/unit/type/network_route_spec.rb:58:in `block (4 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # RuntimeError:
     #   IPv6 routes are not supported on Debian
     #   ./lib/puppet/type/network_route.rb:24:in `block (3 levels) in <top (required)>'

Finished in 4.72 seconds (files took 1.49 seconds to load)
281 examples, 8 failures, 3 pending

the problem here is that our tests don't have the loop over over platforms, which would set the fact — the reason here of course is that types are supposed to be platform independent!

ffrank commented 8 years ago

From a very brief inspection of the output above: I think this works as intended, but the test needs updating to actually expect (and in the process, catch) this exception.

igalic commented 8 years ago

aye! i may have time next week to give it a go and actually fix it

juniorsysadmin commented 7 years ago

@igalic ping

bastelfreak commented 5 years ago

Hello. I'm going to close this PR due to inactivity. Please reopen and rebase it if you're still interested in it.