search

voxpupuli / puppet-network

Types and providers to manage network interfaces
https://forge.puppet.com/puppet/network
Apache License 2.0
66 stars 108 forks source link

Add a `network` class which installs the packages and gems required by #168

Closed rski closed 8 years ago

rski commented 8 years ago

puppet network.

This is regarding issue https://github.com/voxpupuli/puppet-network/issues/45. There are some things that still need to be done (docs, tests etc) but I'd like some feedback on it.

What kind of irks me is that a warning is thrown per https://github.com/voxpupuli/puppet-network/pull/155. even if you include the class which will install ipaddress.

rski commented 8 years ago

@igalic ping

jyaworski commented 8 years ago

I think telling the user we don't officially support their OS is.... a bit much. If we add name, provider, etc it should be able to work for them regardless.

rski commented 8 years ago

Fair enough. Thanks, I'll work with that in mind.

rski commented 8 years ago

@jyaworski better now? edit: i just realised it might sound sarcastic or something. sorry, it's not. Also maybe parametrising ifupdown-extra's name is too much

rski commented 8 years ago

Stuff has come up so I might not be able to see this through, not until 2-3 weeks pass. If anyone else wants to pick it up and go from there feel free.

bastelfreak commented 8 years ago

@rski could you please take a look at the two comments?

rski commented 8 years ago

@bastelfreak I think i'll have time to work on this again during this week, not today though

rski commented 8 years ago

I think it's much better now. Some unit tests and squashing and it should be quite close to merging,

bastelfreak commented 8 years ago

LGTM