search

voxpupuli / puppet-network

Types and providers to manage network interfaces
https://forge.puppet.com/puppet/network
Apache License 2.0
66 stars 107 forks source link

update version dependencies for boolean and filemappper #237

Closed kfowler-embue closed 6 years ago

kfowler-embue commented 6 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

puppet module list

What are you seeing

this module limits versions of dependencies (boolean, filemapper) below their current versions

What behaviour did you expect instead

Expect the latest version of this module to be able to use the latest versions of its dependencies.

Output log

puppet module list

Warning: Module 'puppet-boolean' (v2.0.0) fails to meet some dependencies: 'puppet-network' (v0.9.0) requires 'puppet-boolean' (>= 1.0.1 < 2.0.0) Warning: Module 'puppet-filemapper' (v3.0.0) fails to meet some dependencies: 'puppet-network' (v0.9.0) requires 'puppet-filemapper' (>= 2.0.1 < 3.0.0)

Any additional information you'd like to impart

I understand that the dependency version ranges were probably valid for a long while and that both boolean and and filemapper just went to versions that broke the version rule. I was guessing that your module would likely be okay with the latest dependencies but needed to be tested with them.

bastelfreak commented 6 years ago

Hi @kfowler-embue, thanks for this issue. Can you provide a PR which bumps the version boundaries?

bastelfreak commented 6 years ago

Fixed by https://github.com/voxpupuli/puppet-network/pull/238