search

voxpupuli / puppet-network

Types and providers to manage network interfaces
https://forge.puppet.com/puppet/network
Apache License 2.0
66 stars 109 forks source link

modulesync 2.7.0 #242

Closed bastelfreak closed 5 years ago

bastelfreak commented 6 years ago
alexjfisher commented 5 years ago

Tests are failing on puppet 6 due to the ruby version we're using there. Locally, I can reproduce the failures on puppet 5 with ruby 2.5. Equally, the tests pass on ruby 2.4 with puppet 6.

alexjfisher commented 5 years ago

https://blog.bigbinary.com/2017/10/18/ruby-2.5-has-removed-top-level-constant-lookup.html

EDIT - Confirmed. Just compiled ruby 2.5.0 after reverting https://github.com/ruby/ruby/commit/44a2576f79 and tests pass again.

alexjfisher commented 5 years ago

This is the line that doesn't work in 2.5 https://github.com/voxpupuli/puppet-network/blob/f992867d350177215bde36c2256446459c0a9d2d/spec/unit/provider/network_config/interfaces_spec.rb#L12

reset! is a class method on an inner class or something?? That hasn't been loaded??? https://github.com/voxpupuli/puppet-network/blob/f992867d350177215bde36c2256446459c0a9d2d/lib/puppet/provider/network_config/interfaces.rb#L42