Correct VLAN_RANGE_REGEX.

voxpupuli / puppet-network

Types and providers to manage network interfaces

https://forge.puppet.com/puppet/network

Apache License 2.0

66 stars 107 forks source link

Correct VLAN_RANGE_REGEX. #248

Closed KeithWard closed 5 years ago

KeithWard commented 5 years ago

It appears that the VLAN_RANGE_REGEX being used currently doesn't correctly match vlan's above 999 resulting it applying interfaces even when the vlan interface already exists.

I've Corrected the vlan range regex so that it correctly matches - based on the regex used elsewhere in the module.

ghoneycutt commented 5 years ago

@KeithWard Thanks for the PR! Are you up for adding a few tests that show this works?

KeithWard commented 5 years ago

@ghoneycutt I've added a test for bond1.1001 which should be sufficient as the regex issue only affects vlan tagged interfaces.

bastelfreak commented 5 years ago

thanks!