Windows can't handle the : character in a filename.

voxpupuli / puppet-network

Types and providers to manage network interfaces

https://forge.puppet.com/puppet/network

Apache License 2.0

66 stars 107 forks source link

Windows can't handle the : character in a filename. #253

Open binford2k opened 5 years ago

binford2k commented 5 years ago

This renames the file and then makes a symlink to the original filename when the specs are run. This will allow the module to be installed without errors onto a windows machine.

The other alternatives I considered were things like mocking File.read to magically translate invalid characters, but that seemed like more wtf than this. Happy to consider other approaches though!

Fixes #224

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

vox-pupuli-tasks[bot] commented 2 years ago

Dear @binford2k, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks