search

voxpupuli / puppet-network

Types and providers to manage network interfaces
https://forge.puppet.com/puppet/network
Apache License 2.0
66 stars 107 forks source link

Add stricter types for onboot/hotplug/bonding parameters #257

Open runejuhl opened 4 years ago

runejuhl commented 4 years ago

Adds stricter types for onboot, hotplug and certain bonding parameters.

Also fixes issue in opts-redhat.erb when passed a non-string/non-enumerable value. See https://github.com/voxpupuli/puppet-network/compare/master...runejuhl:add-stricter-types?expand=1#diff-6114de1a6f90ec85830d2eab0f0815f7R3 .

runejuhl commented 4 years ago

What's the @voxpupuli convention when making changes with backward-incompatible changes? Any chance of getting this merged in the near future?

ghoneycutt commented 4 years ago

@runejuhl It is hard to merge this because it has backward compatible changes by adding data types to the class parameters. This is a very good thing, thank you! Since the PR only changes some of the parameters, it cannot easily be merged because someone else then needs to change the remaining ones. If you could add types to the other parameters, we could definitely get this merged. As it is now, it will probably languish unless someone else wants to checkout your work and then do the rest on top of it.

runejuhl commented 4 years ago

Hi @ghoneycutt

Thank you for the comment. I'll try to find some time to put a bit more work into this PR in the not too distant future ...which will probably end up becoming the "not really near future" :wink:

vox-pupuli-tasks[bot] commented 4 years ago

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks