jhoblitt
commented
11 years ago Here's some thoughts on a possible [simple] implementation of vlan support into network_config.
- add a new boolean parameter to the network_config type called
vlan; an alternative possibility would be add some sort of parameter to declare the type of the interface. Eg.raw|bond|bridge|vlan - the debian & redhat providers would both need to be modified to parse the
namevarand or the device name into a raw interface name part and a vlan ID part, if thevlanparameter is true. - in the redhat provider the "vlanness" of an interface could be be detected by either parsing the filename directly or the device variable in the per interface configuration. It seems that perhaps parsing the device variable would be slightly simpler, only requiring a small hook in
parse_fileinstead of having to build two separate lists of files. If it was desired to validate the format of the files being parsed, it might be easier to do it the other way around and track the name of the file that was parsed to valid the device var in general. No modification offormat_file/etc. should be necessary if we are requiring thevlanparam on the type to be set. - in the debian provider the
Instance.initializemethod looks like a good place to parse the name into raw & vlan tagged components.format_filewould need to be modified to inject thevlan-raw-deviceline.
Thoughts/comments/criticisms?
jyaworski
It's highly desirable to be able to configure tagged vlan interfaces for a multiple of reasons but in particular when configuring a host to act as a Linux kernel based hypervisor. In the specific hypervisor scenario (under linux) there is normally a chain of interfaces like:
or
The
$::osfamily == debianandredhatconfiguration file approach for modeling the the relationship of the raw interfaces and the vlan interface are flexible but there is at least one syntax that is fairly similar between them.On
redhat, the ifcfg configuration fileDEVICEvariable provides both the name of the parent raw device and the vlan tag ID. TheVLANvariable also needs to be declared to invoke this magic device name parsing (it has not be tested if it it works without doing this but theVLANvariable is required per the rhel documenation)(from: https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Deployment_Guide/s2-networkscripts-interfaces_802.1q-vlan-tagging.html)
On
debian, theifacedeclaration seems to declare the vlan tag (similar to the redhat DEVICE variable) but doesn't auto-magically seem to imply the parent raw device. A separate sub declaration ofvlan-raw-deviceis needed.(from: http://wiki.debian.org/NetworkConfiguration#Howto_use_vlan_.28dot1q.2C_802.1q.2C_trunk.29_.28Etch.2C_Lenny.29)