Exported members and streams

[cova-fe]

I'm using the feature of exporting members to add servers to a stream. However face issues when upstream resource tries to collect exported resources, as concat searches in /etc/nginx/conf.d/whatever-upstream.conf instead of /etc/nginx/conf.stream.d/whatever.

Looking at upstream/member.pp code, there is a

target  => "${::nginx::conf_dir}/conf.d/${upstream}-upstream.conf",

shouldn't be the same as upstream.pp, that uses the parameter $upstream_context to decide where to place the conf file, something like

target  => "${::nginx::conf_dir}/${conf_dir_real}/${upstream}-upstream.conf",

(with related logic, of course?)

I'm testing a small patch as described, but maybe I got the whole logic wrong (very likely, I fear...). Any hint?

[igalic]

I actually think the logic should be simplified, or unified, not duplicated.

It took us at $co a while to figure out what we're doing wrong when using this module, when we didn't set nginx::stream => on

a lot of the concept that we're exposing are very unintuitive

[cova-fe]

I see your point; however stream flag is indeed on (as the needed stream code block is present in conf files.)

Unifying it seems to be a good idea, however I wonder how this can be done in an exported resource, that is declared with only a @@nginx::resource::upstream::member and no other references to the same module classes...

[igalic]

possibly related, of the things i'm missing in @@nginx::resource::upstream::member is an assignment of port or protocol… https://github.com/voxpupuli/puppet-nginx/issues/1055

[cova-fe]

see https://github.com/voxpupuli/puppet-nginx/pull/1061

[AranVinkItility]

Just lost a lot of time because settings stream => on on the init of the module is not documented in the README.

It should throw an error in my opinion when defining streams when stream is not set to on