search

voxpupuli / puppet-nginx

Puppet Module to manage NGINX on various UNIXes
https://forge.puppet.com/puppet/nginx
MIT License
471 stars 881 forks source link

Latest version no longer works on DragonFlyBSD #619

Closed strangelittlemonkey closed 9 years ago

strangelittlemonkey commented 9 years ago

Partially due to the params.pp being used now and not mentioning DragonFly, which I can fix in a couple minutes, but something deeper was changed that's now generating an invalid config even when that's not an issue. I'll try to get it functional again and send a pull request. Any help along the way would be greatly appreciated.

strangelittlemonkey commented 9 years ago

Ok. It seems if you don't have a /var/log/nginx directory it will not make one, but instead just fail. Should I address that in the pull request as well?

3flex commented 9 years ago

Did some research: Dragonfly is a fork of FreeBSD. In FreeBSD the following log files are used for nginx by default:

I'd expect DragonFly to be the same. So what should happen ideally is that the logdir is set to /var/log for both FreeBSD and DragonFlyBSD to reflect the distribution default, and the default log file names should be as above. There should be no need for this module to create a log directory in this case.

Are you up to creating a PR to cover that?

strangelittlemonkey commented 9 years ago

When I put 'FreeBSD', 'DragonFlyBSD':, it wanted to make /var/log/nginx/[access|error].log. I can take care of that too though.

3flex commented 9 years ago

@strangelittlemonkey not sure if you're still working on this, but there's active conversation in #635 and I don't want your submission and #635 to duplicate any work!