voxpupuli / puppet-nginx

Puppet Module to manage NGINX on various UNIXes
https://forge.puppet.com/puppet/nginx
MIT License
470 stars 881 forks source link

Looking for Maintainer #844

Closed jfryman closed 7 years ago

jfryman commented 8 years ago

Hello everyone,

I am looking for a maintainer for this module. For a multitude of reasons, I have come to the understanding that it is time for me to let this thing go.

I've been staring at this repo, and eagerly tried to work up the energy to tackle some issues or to finish this almost two year long refactor I've been "working on". But, each time I do, I just don't have it in me. I'm exhausted by the time that I get home from work, and I cannot properly care for this module as it should be cared for.

I'm burnt. Quite hard. It has been a very long and tough 36 months for me both personally and professionally.

To that end, I would like to hand this over to someone who would like to take ownership of it. @3flex has done a wonderful job maintaining this module over the years. @3flex if you want it, it's yours. We can transfer ownership, and I'll step out of the way. If not, we'll find a good home for this. But, consider this a formal ask for new leader for this module.

For all of you who have used this module, thanks for your support and I hope you continue to find value from it. I hope to see some of you around.

:heart:

@jfryman

3flex commented 8 years ago

@jfryman I'd firstly like to thank you for the faith you've placed in me, and to offer me the role of maintainer for this module. I hope that freeing yourself of some of these responsibilities will help.

When I started contributing I was mainly doing it to keep myself entertained while between jobs (I'd just relocated overseas and was searching for work) and found it to be a great opportunity to teach myself git & rspec (and automated testing in general), to make some kind of meaningful open source contribution and of course to gain a deeper appreciation for and understanding of nginx :)

I feel I can claim credit for many improvements in this module, and am proud of what I've accomplished. I also hope I didn't make too many mistakes along the way!

That said, my level of contribution has dropped sharply since that initial burst of activity, and I don't feel it's appropriate for me to take ownership. I have lots of ideas for improvement but am honestly unlikely to find the time or motivation in the near future to implement them, and it wouldn't be fair to users of this module to have to wait on me alone to perform QA on PRs or let issues languish for sometimes months on end.

I think this is exactly the type of problem @voxpupuli was designed to solve! Transferring the module to them is what I'd do in your position. The module would benefit greatly from some of the tooling they've implemented, and it will receive the care it deserves from a much larger team of collaborators. I'd like to be a "module contributor" (in their words) meaning I'd still have commit and merge access, but the benefit is that when I'm unavailable there are many others who can pick up the slack.

There's some good background about @voxpupuli and what they do at https://voxpupuli.org/blog/2016/06/10/voxpupuli-opensource-speedtrain/

All the best @jfryman!

andrewwippler commented 8 years ago

I am an avid user of nginx and have fallen in love with this module - I use it regularly. I can understand the life balance difficulty you are going through and how you feel burnt out from a long 36 month stretch. I agree that you need a break and should step away for awhile.

I am willing to step in as maintainer of this module and your selinux module provided the following conditions are met:

My qualifications:

Here is where I can improve:

3flex commented 8 years ago

@jfryman I've created a PR at https://github.com/jfryman/puppet-nginx/pull/849 which will aid the migration to vox pupuli if that's the direction you choose to go.

astrostl commented 8 years ago

This is why Vox Pupuli exists. Seems like a good call.

Maybe Andrew could join them and make it a twofer?

jfryman commented 8 years ago

Thanks everyone. I think moving to Vox is the right move. Just need to figure out what needs to happen, and carve out time to do that.

astrostl commented 8 years ago

FWIW, I'd just go to their IRC channel and say, "uncle"

3flex commented 8 years ago

See https://voxpupuli.org/docs/#migrating-a-module-to-voxpupuli

I can handle all of this for you, though my access level on this repository likely has to be increased so I can do the transfer (I won't have the rights otherwise).

I think I've done the hard part with #849, everything else looks very straightforward.

igalic commented 8 years ago

hi people o/~

hello and and early (or perhaps late?) welcome to @voxpupuli!

most of the modules we get are just thrown over the wall, and then cleaned up. We have quite a bit of practice in the latter so don't worry or shy away from doing that.

Please let us know who of you to add to the admin team for the initial transfer.

bastelfreak commented 8 years ago

Hai! I'm one of the Vox Pupuli members. We would be very happy to maintain this module. Just ping us on IRC 24/7 and we will fiddle out the details.


okay @igalic was faster.

3flex commented 8 years ago

I've merged #849. It's a massive changeset but only affects 3 manifest files, see https://github.com/voxpupuli/puppet-nginx/pull/849/files#diff-3bfa339c375e139166a7afc6cb8c5b62

I don't think anything in there would be controversial and hopefully makes the process a bit smoother. Will still need @jfryman to pull a few levers to get this move going.

nibalizer commented 8 years ago

@andrewwippler re: attribution When we migrate a module to voxpupuli, we often put a note about authorship in the Readme, thanking the original author for creating the module. This isn't as flashy as keeping it in the author's namespace, but is one way we try to preserve the credit that @jfryman and others clearly deserve.

If you have other ideas on how we can thank and credit these original authors, I'd be very interested.

And as others have stated, you're very welcome in voxpupuli!

jfryman commented 8 years ago

@3flex You should see the levels being pulled. I'm in the IRC room chatting with the team now. This module has been transferred to their namespace. The team is working on uploading to the forge, and once that has been updated I'll deprecate my module on the forge with the 999.999.999 version and a link to the new group.

To the @voxpupuli/collaborators team: thanks for existing, and for offering to curate this module.

I'll close this issue out once the final push is done.

cyberious commented 8 years ago

@jfryman thanks for you long work on this, we are heavy users of it and as a Voxilpupuli member I would be happy to chime in on PR's but, like you, I have no energy by the time I get home.

3flex commented 8 years ago

Just want to mention that I hope to still have commit access after the move!

roidelapluie commented 8 years ago

@3flex yes you do

bastelfreak commented 8 years ago

Hai @3flex, I sent you a github invitation to be part of the voxpupuli collaborators group, which will grant to access to our modules. Join us on IRC if you have any questions.

raphink commented 8 years ago

Happy to see @voxpupuli being put to good use again. It's great when a maintainer is able to step aside while being sure that their work will be well taken care of.

bbriggs commented 8 years ago

That's why we're here :)

On Mon, Aug 29, 2016 at 5:00 PM, Raphaël Pinson notifications@github.com wrote:

Happy to see @voxpupuli https://github.com/voxpupuli being put to good use again. It's great when a maintainer is able to step aside while being sure that their work will be well taken care of.

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/voxpupuli/puppet-nginx/issues/844#issuecomment-243254779, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPdK43YXHdK4OidKvPpxwAIaXU5Yq_yks5qk0iHgaJpZM4JZugP .