search

voxpupuli / puppet-nrpe

Puppet module for NRPE
http://forge.puppetlabs.com/puppet/nrpe
Apache License 2.0
2 stars 14 forks source link

Adding interface for Hiera and nrpe resources #16

Closed jehane closed 5 years ago

jehane commented 6 years ago

It would be useful to add nrpre ressources through hiera. A pull request exist for pdcat/puppet-module-nrpe ( https://github.com/pdxcat/puppet-module-nrpe/pull/42 )

Is it possible to add this feature ?

Thanks

alexjfisher commented 6 years ago

@jehane Seems reasonable, so I created https://github.com/voxpupuli/puppet-nrpe/pull/17.

Does that work for you?

(https://github.com/pdxcat/puppet-module-nrpe/pull/42 has some slightly odd implementation for plugins. I think the idea was you might want to be able to pass a template in for plugins. In practice, I'm not sure how well that would work. Would the variables you want to use in your template be in scope when created by the nrpe class? Not sure. Either way, I think I'd implement this by adding a template parameter to the nrpe::plugin class.)

jehane commented 6 years ago

It look great.

We want to add/modify commands in nrpe config files (changing parameters for checks, adding some new one, etc). And on a second time, deploy scripts for specific checks (who are not available through deb or rpm).

And do all of it through hiera, of course

Thansk again