voxpupuli / puppet-openssl

Puppet OpenSSL module

Apache License 2.0

38 stars 84 forks source link

Wrong variable type in template #100

Closed brow86 closed 1 year ago

brow86 commented 5 years ago

On the following line there is a $ when there should be a @.

https://github.com/camptocamp/puppet-openssl/blob/6060123d08656e78b300c1badba2bfec2c2ed01b/templates/cert.cnf.erb#L17

I forked the repo, updated it, and tested it after the change. Works well.

raphink commented 5 years ago

Good catch. Can you open a PR please?

makeacode commented 3 years ago

we just got bit by this bug after upgrading our module to the 1.14. can we get this merged please?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

makeacode commented 3 years ago

no fix?

raphink commented 3 years ago

101 has a fix for it, but needs rebasing.

zilchms commented 1 year ago

@brow86 same as with the PR :) do you want to close this?

smortex commented 1 year ago

Yeah, overcome by events. Closing.