voxpupuli / puppet-openssl

Puppet OpenSSL module
Apache License 2.0
38 stars 84 forks source link

1.13.0 introduced bug in `openssl::export::pkcs12` #110

Closed walkamongus closed 4 years ago

walkamongus commented 4 years ago

The in_pass and out_pass params are set to Boolean at https://github.com/camptocamp/puppet-openssl/blob/master/manifests/export/pkcs12.pp#L19, which doesn't allow for inputting the passwords. The param type should probably be Variant[Boolean, String] or something similar.

raphink commented 4 years ago

Thanks! Actually, the mistake comes from the default value being false, when it should be undef for a string. I'll fix that.