search

voxpupuli / puppet-openssl

Puppet OpenSSL module
Apache License 2.0
38 stars 84 forks source link

add cert_file type #124

Closed rtib closed 3 years ago

rtib commented 3 years ago

A cert_file resource is intended to behave some similar to file, but respecting the content as X.509 certificate. In this initial version it is able to download a certificate from a given URL and to store it in a local file in the chosen format PEM or DER.

puppet-community-rangefinder[bot] commented 3 years ago

cert_file is a type

that may have no external impact to Forge modules.

This module is declared in 2 of 576 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

rtib commented 3 years ago

It needs unit tests, therefore still in draft, but open for discussion and comments.

rtib commented 3 years ago

It actually fails with Puppet 5. Will the module support Puppet 5 for a long time?

rtib commented 3 years ago

Rebased onto #125

raphink commented 3 years ago

I just merged #125. Could you rebase to reduce the diff please?

rtib commented 3 years ago

Rebased onto master and squashed. Unfortunately, tests downloading files are unstable on travis-ci, and now breaking the build again.

rtib commented 3 years ago

I think it's done now. I could run the spec test locally multiple times with stable results. It may be a good idea to restart the travis-ci build a couple of times before merging to assure it's stable.