search

voxpupuli / puppet-openvpn

OpenVPN module for puppet including client config/cert creation
Apache License 2.0
113 stars 197 forks source link

Drop Ubuntu 16.04 #413

Closed jkroepke closed 3 years ago

jkroepke commented 3 years ago

From: https://github.com/voxpupuli/puppet-openvpn/pull/412#issuecomment-922243167

We can drop it along with Debian 9.

I wouldn't. https://wiki.debian.org/LTS. It is still supported until 2022.

I'm going to modify the actions, since the logic will be changed in modulesync 4.2. See: https://github.com/voxpupuli/puppet-openvpn/pull/411 Looks like it's not ready. (tests failing)

root-expert commented 3 years ago

I'm preparing a PR for Debian 11, I want to release it before we introduce the breaking changes :smile:

jkroepke commented 3 years ago

I want to release it

I hope, it will not take soo much time. Maintain and rebase 3 PRs will consume some time, too. :-)

bastelfreak commented 3 years ago

can you please also cleanup ubuntu 16.04 in the code? at least https://github.com/voxpupuli/puppet-openvpn/blob/ef0ff4cee842affd62d33ea84c5609ac5585095c/spec/classes/openvpn_init_spec.rb#L22 mentions 16.04.

jkroepke commented 3 years ago

can you please also cleanup ubuntu 16.04 in the code? at least

I simplify the os list in openvpn_init_spec.rb

root-expert commented 3 years ago

can you please also cleanup ubuntu 16.04 in the code? at least

https://github.com/voxpupuli/puppet-openvpn/blob/ef0ff4cee842affd62d33ea84c5609ac5585095c/spec/classes/openvpn_init_spec.rb#L22

mentions 16.04.

I dropped it here

jkroepke commented 3 years ago

I dropped it here

Okay, the conflict at the rebase will mention me. :)

root-expert commented 3 years ago

Please use rebase instead of merge commit @jkroepke

root-expert commented 3 years ago

@jkroepke Can you do a final rebase against master? Afterwards I'll merge this and the other PR

jkroepke commented 3 years ago

done