search

voxpupuli / puppet-openvpn

OpenVPN module for puppet including client config/cert creation
Apache License 2.0
113 stars 198 forks source link

Replace ns_cert_type with remote_cert_tls (**client config regeneration needed**) #415

Closed jkroepke closed 3 years ago

jkroepke commented 3 years ago

Pull Request (PR) description

https://community.openvpn.net/openvpn/wiki/DeprecatedOptions#Option:--ns-cert-type

The OpenVPN parameter --ns-cert-type is deprecated since some OpenVPN version. --remote-cert-tls is a drop-in replacement. Current OpenVPN versions map --ns-cert-type to --remote-cert-tls and raise a deprecation warning.

We could drop --ns-cert-type (default to true in this module) and set --remote-cert-tls (default to false in this module) to true.

This is a breaking change, since client configs needs to be re-generated.

Note for affected users

You can still define ns-cert-type through custom_options.

This Pull Request (PR) fixes the following issues