voxpupuli / puppet-php

Generic Puppet module to manage PHP on many platforms
http://forge.puppet.com/puppet/php
MIT License
87 stars 268 forks source link

Incompatible with Puppet 4 #121

Closed ghost closed 8 years ago

ghost commented 8 years ago

This module is incompatible with Puppet 4, it would be very handy for me, but the environment I'm using is running version 4.

globin commented 8 years ago

We are definitely happy to make this module puppet 4 compatible, already put some effort into it and will do so further, but are currently forced to use puppet 3 in our own projects and infrastructures due to many other requirements, so we don't get edgecases or sometimes newly introduced problems.

If you find problems we'll always be happy and thankful to receive a pull request fixing these.

Cheers :beers:

mmoll commented 8 years ago

We need more test-coverage and rewrite the spec tests to use rpsec-puppet-facts, that made the migration of all the modules in @theforeman much easier. notime

globin commented 8 years ago

Cannot reproduce with:

vagrant@puppet-php:~$ /opt/puppetlabs/bin/puppet -V
4.2.2

Hiera:

php::extensions:
  curl: {}
  json: {}
  intl: {}
  mysql: {}
  apc:
    package_prefix: php-
    settings:
      apc.stat: 1
      apc.stat_ctime: 1
  xdebug:
    settings:
      xdebug.max_nesting_level: 1000
      xdebug.remote_enable: 'On'
      xdebug.default_enable: 'On'
      xdebug.remote_connect_back: 'On'

php::settings:
  Date/date.timezone: Europe/Berlin

php::fpm::settings:
  PHP/short_open_tag: 'On'

Output:

==> default: Running provisioner: puppet...
==> default: Running Puppet with environment production...
==> default: stdin: is not a tty
==> default: Notice: Compiled catalog for puppet-php.localdomain in environment production in 1.72 seconds
==> default: Notice: /Stage[main]/Php::Repo::Ubuntu/Apt::Ppa[ppa:ondrej/php5]/Package[software-properties-common]/ensure: created
==> default: Notice: /Stage[main]/Php::Repo::Ubuntu/Apt::Ppa[ppa:ondrej/php5]/Exec[add-apt-repository-ppa:ondrej/php5]/returns: executed successfully
==> default: Notice: /Stage[main]/Apt::Update/Exec[apt_update]/returns: executed successfully
==> default: Notice: /Stage[main]/Apt::Update/Exec[apt_update]: Triggered 'refresh' from 1 events
==> default: Notice: /Stage[main]/Php::Packages/Package[php5-cli]/ensure: created
==> default: Notice: /Stage[main]/Php::Fpm/File[/etc/init/php5-fpm.override]/ensure: defined content as '{md5}5d930cc584c88aa89c6ff43df3082a12'
==> default: Notice: /Stage[main]/Php::Fpm/Package[php5-fpm]/ensure: created
==> default: Notice: /Stage[main]/Php::Fpm::Config/File[/etc/php5/fpm/php-fpm.conf]/content: content changed '{md5}69e2a37717fc08d05b75fc24e40f0ea5' to '{md5}a5d2f807c7650c1f1cc897f683eff005'
==> default: Notice: /Stage[main]/Php::Dev/Package[php5-dev]/ensure: created
==> default: Notice: /Stage[main]/Php::Fpm/Php::Fpm::Pool[www]/File[/etc/php5/fpm/pool.d/www.conf]/content: content changed '{md5}7facd89c7887e539559a46516aaf55e8' to '{md5}015cfedac2a22b40b2c6cd7eb232d3d1'
==> default: Notice: /Stage[main]/Php::Cli/Php::Config[cli]/Php::Config::Setting[/etc/php5/cli/php.ini: Date/date.timezone]/Ini_setting[/etc/php5/cli/php.ini: Date/date.timezone]/ensure: created
==> default: Notice: /Stage[main]/Php::Composer/Exec[download composer]/returns: executed successfully
==> default: Notice: /Stage[main]/Php::Composer/File[/usr/local/bin/composer]/mode: mode changed '0644' to '0555'
==> default: Notice: /Stage[main]/Php::Pear/Exec[::php::pear::auto_discover]/returns: executed successfully
==> default: Notice: /Stage[main]/Php/Php::Extension[curl]/Package[php5-curl]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[curl]/Exec[/usr/sbin/php5enmod curl]: Triggered 'refresh' from 1 events
==> default: Notice: /Stage[main]/Php/Php::Extension[json]/Exec[/usr/sbin/php5enmod json]: Triggered 'refresh' from 1 events
==> default: Notice: /Stage[main]/Php/Php::Extension[intl]/Package[php5-intl]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[intl]/Exec[/usr/sbin/php5enmod intl]: Triggered 'refresh' from 1 events
==> default: Notice: /Stage[main]/Php/Php::Extension[mysql]/Package[php5-mysql]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[mysql]/Exec[/usr/sbin/php5enmod mysql]: Triggered 'refresh' from 1 events
==> default: Notice: /Stage[main]/Php/Php::Extension[apc]/Package[php-apc]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[xdebug]/Package[php5-xdebug]/ensure: created
==> default: Notice: /Stage[main]/Php::Fpm::Config/Php::Config[fpm]/Php::Config::Setting[/etc/php5/fpm/php.ini: Date/date.timezone]/Ini_setting[/etc/php5/fpm/php.ini: Date/date.timezone]/ensure: created
==> default: Notice: /Stage[main]/Php::Fpm::Config/Php::Config[fpm]/Php::Config::Setting[/etc/php5/fpm/php.ini: PHP/short_open_tag]/Ini_setting[/etc/php5/fpm/php.ini: PHP/short_open_tag]/value: value changed 'Off' to 'On'
==> default: Notice: /Stage[main]/Php/Php::Extension[apc]/Php::Config[apc]/Php::Config::Setting[/etc/php5/mods-available/apc.ini: apc.stat]/Ini_setting[/etc/php5/mods-available/apc.ini: apc.stat]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[apc]/Php::Config[apc]/Php::Config::Setting[/etc/php5/mods-available/apc.ini: apc.stat_ctime]/Ini_setting[/etc/php5/mods-available/apc.ini: apc.stat_ctime]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[apc]/Exec[/usr/sbin/php5enmod apc]: Triggered 'refresh' from 2 events
==> default: Notice: /Stage[main]/Php/Php::Extension[xdebug]/Php::Config[xdebug]/Php::Config::Setting[/etc/php5/mods-available/xdebug.ini: xdebug.max_nesting_level]/Ini_setting[/etc/php5/mods-available/xdebug.ini: xdebug.max_nesting_level]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[xdebug]/Php::Config[xdebug]/Php::Config::Setting[/etc/php5/mods-available/xdebug.ini: xdebug.remote_enable]/Ini_setting[/etc/php5/mods-available/xdebug.ini: xdebug.remote_enable]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[xdebug]/Php::Config[xdebug]/Php::Config::Setting[/etc/php5/mods-available/xdebug.ini: xdebug.default_enable]/Ini_setting[/etc/php5/mods-available/xdebug.ini: xdebug.default_enable]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[xdebug]/Php::Config[xdebug]/Php::Config::Setting[/etc/php5/mods-available/xdebug.ini: xdebug.remote_connect_back]/Ini_setting[/etc/php5/mods-available/xdebug.ini: xdebug.remote_connect_back]/ensure: created
==> default: Notice: /Stage[main]/Php/Php::Extension[xdebug]/Exec[/usr/sbin/php5enmod xdebug]: Triggered 'refresh' from 2 events
==> default: Notice: /Stage[main]/Php::Fpm::Service/Service[php5-fpm]: Triggered 'refresh' from 7 events
==> default: Notice: Applied catalog in 238.02 seconds
==> default: Configuring cache buckets...
ghost commented 8 years ago

This was an assumption my part because the page for this module in puppet forge says it's compatible with 3. When I tried it with 4 it didn't work and I completely misread the error message. The issue is with example42/yum having no read permissions on metadata.json for "other" users. Just wanted to give an update and say I'm sorry for wasting developers time because of my failure to understand why I was getting an error.