search

voxpupuli / puppet-pkgng

A Puppet package provider for FreeBSD's PkgNG package manager.
https://forge.puppet/com/puppet/pkgng
Apache License 2.0
39 stars 33 forks source link

Allow modifying / disabling repos in /etc #105

Closed igalic closed 4 years ago

igalic commented 4 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

according to the README,

Disabling the FreeBSD default repository is done with:

pkgng::repo { 'FreeBSD':
 enabled => false,
}

What are you seeing

This, however, just adds a file in /usr/local/etc/pkg/repos, but that does not seem to actually disable the repo

What behaviour did you expect instead

I would expect to disable the FreeBSD repo, by modifying /etc/pkg/FreeBSD.conf

Any additional information you'd like to impart

I don't know if this is a bug in pkg.

brooksdavis commented 4 years ago

Is false a synonym for no in libucl? I've noticed that libucl is to accepting of nonsense (e.g. misspelling enabled and enable results is silently doing nothing).

igalic commented 4 years ago

debugged this with the help of @RhodiumToad on IRC:

22:09 <RhToad> what does  pkg stats   output?
22:09 <RhToad> specifically for  Number of repositories:
22:10 <RhToad> I just put a copy of that FreeBSD.conf onto one of my VMs and it has correctly disabled access to the freebsd repo

Turns out the number was, indeed 1. The pkg: leatherman: duplicate dependency listing: curl (among many other packages) were resolved with pkg upgrade -f;