search

voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
70 stars 173 forks source link

Make chroot parameter default to 'n' #224

Closed raphink closed 5 years ago

lelutin commented 5 years ago

Hi there, I've pushed 98fb0ce on top of this work on my fork of the module. It makes the $chroot parameter default to false and adds a deprecation warning if undef is used explicitely.

raphink commented 5 years ago

@lelutin there never was a release of this module with the $chroot parameter, it was only in git. So as far as I'm concerned the API is not fixed and there is no need for a deprecation warning.

lelutin commented 5 years ago

@raphink oh! right then my point about deprecation warning is moot. it would be nice then to make the parameter default to false and remove the undef value entirely, no?

raphink commented 5 years ago

Alright, let's merge this then.