voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
70 stars 173 forks source link

Introduce new parameter 'config' for adding configuration using hiera #240

Closed ruriky closed 5 years ago

ruriky commented 5 years ago

With configs hash user can define configuration values in hiera.

This is a simplified replacement for https://github.com/camptocamp/puppet-postfix/pull/232

ruriky commented 5 years ago

Hi @raphink

Thanks for your comments. I was trying to use the same style as rest of the init.pp where most of the values were set to undef. I would also prefer setting the default value to empty hash and also removing the "if $configs" line. Would that be ok?

raphink commented 5 years ago

Sure, that's fine with me