search

voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
70 stars 174 forks source link

support fedora versions 28 and later #247

Closed qs5779 closed 4 years ago

qs5779 commented 5 years ago

I updated the spec tests, and have these changes active on a live Fedora 30 Server system.

raphink commented 5 years ago

Sorry for not addressing this earlier. Would you mind rebasing this PR?

qs5779 commented 5 years ago

I tried to quickly deal with it when I first received you message, but "Fedora" being a RedHat family member with many more versions than rhel, coupled with fact I am now working on Archlinux support too, I believe a much better approach would be to leverage hieradata combined with the service_provider fact. That should make the logic much simpler.

If you disagree, please advise, and will accept your direction.

qs5779 commented 5 years ago

I decided to rebase my changes. All spec tests passed after rebasing.

raphink commented 5 years ago

It's true that hiera data would probably simply this logic. I'd welcome a patch in this direction if you want to take it.

qs5779 commented 4 years ago

I am closing this PR as I have finally had time to simplify the logic by leveraging hieradata. I will submit the new PR momentarily.