search

voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
70 stars 174 forks source link

add retry and proxywrite for debian family OSes #253

Closed Dan33l closed 5 years ago

Dan33l commented 5 years ago

Fixes #252

It looks that it is missing retry entry only in template of Debian family OSes. It is already present in others families.

It looks that it is missing proxy_write entry in RedHat and Debian OSes. Accordingly with proxy_write_maps it looks that it should be present also in CentOS7 at least. But to be preservative, i only added it in Debian family.

Dan33l commented 5 years ago

It looks that camptocamp/augeas have dependencies puppetlabs/stdlib (>= 3.2.0 < 6.0.0). But during acceptance puppetlabs/stdlib 6.0.0 is installed and so can not install camptocamp/augeas.

I am surprised that PR #246 had used puppetlabs-stdlib (v5.2.0) https://travis-ci.org/camptocamp/puppet-postfix/jobs/529839716#L1081

Dan33l commented 5 years ago

@mcanevet @raphink can we use puppetlabs/stdlib 6.0.0 with camptocamp/augeas ?

If yes i'll propose a PR to modify camptocamp/augeas metadata.

raphink commented 5 years ago

Sure version 6.0.0 should work

Dan33l commented 5 years ago

stdlib dependency looks to be removed: https://github.com/camptocamp/puppet-augeas/pull/73

A new release of the camptocamp/augeas should be enough.

raphink commented 5 years ago

puppet-augeas 1.8.0 released

Dan33l commented 5 years ago

puppet-augeas 1.8.0 released

Nice. I restart the CI with a Close/Open of this PR.

raphink commented 5 years ago

(or you could have asked me and I would have restarted the build :wink: )

Dan33l commented 5 years ago

(or you could have asked me and I would have restarted the build wink )

I didn't want to disturb you. This way I was autonomous.

The PR should be ready for a review

Dan33l commented 5 years ago

thank you

kenyon commented 5 years ago

This actually fixes #204.