voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
70 stars 174 forks source link

Switch to upstream default for `mydestination` #256

Closed kenyon closed 1 year ago

kenyon commented 5 years ago

It is less surprising if the puppet module's default configuration matches a standard default postfix configuration.

raphink commented 5 years ago

I understand the idea, but I'm not really keen on changing defaults. You can easily change that value in hiera with postfix::mydestination in your common data file.

kenyon commented 5 years ago

Why would the module defaults be different from standard Postfix defaults though? That’s a bit weird.

kenyon commented 5 years ago

In this particular case, not having localhost in $mydestination breaks delivery of most system-generated mail going to root@localhost.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gcoxmoz commented 3 years ago

Obligatory comment to keep this alive. stale-bot is gross.

kenyon commented 1 year ago

I missed this in release 3.0.0 #331 :(

smortex commented 1 year ago

A breaking release was merged to remove Puppet 6 (#351). Let's not miss the opportunity again and merge this!