voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
70 stars 174 forks source link

Postfix version facts #267

Closed cbehlmer closed 3 years ago

cbehlmer commented 4 years ago

Added Postfix version facts

raphink commented 4 years ago

Thanks for the PR. The path is wrong, it should be in lib/facter, not lib

raphink commented 4 years ago

That's looking much better! Now we just need some tests and we're good to go!

raphink commented 4 years ago

@cbehlmer lgtm. Could you add unit tests with example outputs of postconf mail_version command please?

raphink commented 3 years ago

@cbehlmer do you want to address the last comments to finish this PR?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.