search

voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
71 stars 174 forks source link

Update RedHat master.cf to RHEL7 #277

Closed gcoxmoz closed 2 years ago

gcoxmoz commented 4 years ago

As mentioned in #219 there are a number of places where the puppet-pushed master.cf differs from the one provided by a default install.

Using #219 as a starting point I've gone through and made a series of small commits so that it's fairly obvious what changes are being made. The idea here is to modernize the puppet config, and reduce the differences experienced during an initial puppetization of a pristine host.

raphink commented 4 years ago

I really need to tackle that change… That said, it's a backward incompatible change, so I keep pushing it. @mcanevet what do you think?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gcoxmoz commented 3 years ago

worthless comment to stave off stalebot.

vchepkov commented 3 years ago

Curious, why have bunch of erb files instead of one general epp template with configurable sections?

gcoxmoz commented 3 years ago

I edited the erb file that was already in the repo. I'm not opposed to doing it some other way, but considering stalebot is the most engagement I'm seeing from camptocamp, I'm not inclined to pour more time on a reengineering effort if they're not interested in PRs.

vchepkov commented 3 years ago

It was a general question, not to this particular PR. btw, fedora and rhel8 also have similar config

vox-pupuli-tasks[bot] commented 2 years ago

Dear @gcoxmoz, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

gcoxmoz commented 2 years ago

Dear Bot Maintainer, You've called this PR out for failing -travis-, which hasn't worked for a year. I don't think anyone is seriously looking at any PRs here. I was already miffed that this was getting nitpicked. You win.