search

voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
70 stars 174 forks source link

Fix hardcoded map path #287

Closed towo closed 3 years ago

towo commented 3 years ago

The relationship definition for the map path in Postfix::Transport was hardcoded, so that any non-standard $file parameter did not create an automatic refresh of the map, even if it is defined as a Postfix::Hash.

Fixed be replacing the hardcoded string with the $file variable, which means no change with expected behaviour.

raphink commented 3 years ago

OK, that works. What about the empty comment at the end of the line?

towo commented 3 years ago

Yeah, I'm not sure what changed with the CI builds, could probably use another trigger. :)

smortex commented 3 years ago

@towo CI seems to be currently broken on master. I opened #289 a few days ago for a proposal of a fix but did not saw that you where also working on this. I think you are lacking the bits in 118265cf325de63726290786420ead4197b0616d from this PR which fixed acceptance tests.

towo commented 3 years ago

@smortex Ah, great. I'd just wait for your PR to be merged then, I can just throw away any leftover test fixes while rebasing onto it. :+1:

towo commented 3 years ago

Well, @smortex's fixes are in, but CI still seems to be a bit of an issue.

smortex commented 3 years ago

Yeah, I saw this in #288, it's supposed to be fixed by 32f0991b90fdaf4cc63c283a8352fe33d0af4696 in this PR but Travis-CI.org is only able to fail after hours of waiting. I spend a whole day trying to move forward on this issue, only to give up at the end :unamused:.

If you can afford the time you can give it a shot, and if you succeed, please tell me! Maybe these problems I experienced where transient ones :shrug: