search

voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
70 stars 174 forks source link

master.cf.common.erb: fix smtp_bind_address typo #293

Closed farlerac closed 3 years ago

farlerac commented 3 years ago

smtpd_bind_address -> smtp_bind_address

farlerac commented 3 years ago

smtpd_bind_address is likely a typo, should be smtp_bind_address

raphink commented 3 years ago

Is this a change in new versions of Postfix, or a bug in the module?

farlerac commented 3 years ago

IMO this is a bug in the module. There is no option named smtpd_bind_address for Postfix, so I believe it is a typo. The correct option is smtp_bind_address.

raphink commented 3 years ago

So this has been broken for over 10 years without anybody noticing. I wonder if fixing this will change the default behavior.

farlerac commented 3 years ago

This only comes up in the master.cf if use_amavisd == true so perhaps there's not many people using it.

raphink commented 3 years ago

Right. I'll merge.