voxpupuli / puppet-prometheus

Puppet module for prometheus
https://forge.puppet.com/puppet/prometheus
Apache License 2.0
60 stars 238 forks source link

blackbox_exporter should validate config if version >= 0.13.0 #322

Open mapa3m opened 5 years ago

mapa3m commented 5 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

class { 'prometheus::blackbox_exporter':
    version => '0.14.0',
    modules => {
      'http_2xx' => {
        'prober' => 'http',
        'foo' => 'bar',
        'http'   => {}
      }
    }
  }

What are you seeing

Config file is generated, copied over /etc/blackbox-exporter.yaml and, and blackbox_exporter dies on restart

What behaviour did you expect instead

Validation error

Output log

Any additional information you'd like to impart

Config validation functionality is available in blackbox_exporter version 0.13.0 and up.

TheMeier commented 4 months ago

@mapa3m care to provide a merge request for that?